[
https://issues.apache.org/jira/browse/EAGLE-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430118#comment-15430118
]
ASF GitHub Bot commented on EAGLE-482:
--------------------------------------
GitHub user haoch opened a pull request:
https://github.com/apache/incubator-eagle/pull/371
EAGLE-482 Fix checkstyle configuration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haoch/incubator-eagle EAGLE-482
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/371.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #371
----
commit cd9c82f02f2b9b334331f5c8b0c5c85aba6ea6b3
Author: Hao Chen <[email protected]>
Date: 2016-08-19T04:34:07Z
Refine checkstyle configuration
commit 47e71e2f7383bbf42a5ec6b1564786ec8810931b
Author: Hao Chen <[email protected]>
Date: 2016-08-19T05:58:25Z
Automatically format code according to checkstyle
commit 309c1bfa172a60c35f2709c47f000b372cbdd778
Author: Hao Chen <[email protected]>
Date: 2016-08-22T06:27:36Z
Fix embedded hbase
----
> Fix checkstyle configuration
> ----------------------------
>
> Key: EAGLE-482
> URL: https://issues.apache.org/jira/browse/EAGLE-482
> Project: Eagle
> Issue Type: Bug
> Reporter: Hao Chen
> Assignee: Hao Chen
>
> Recently community contributed the checkstyle for eagle which is good but not
> well defined, so we need to
> 1. Refine checkstyle configuration following Google Java Code Style
> 2. Basically reformat code following the checkstyle.
> 3. (Later) continue reformatting left code to make sure all code clean
> 4. Turn on "failOnViolation" to force all code following the same style
> otherwise fail to build.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)