[
https://issues.apache.org/jira/browse/EAGLE-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430246#comment-15430246
]
ASF GitHub Bot commented on EAGLE-484:
--------------------------------------
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/369#discussion_r75628734
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/coordination/model/PolicyWorkerQueue.java
---
@@ -72,6 +76,24 @@ public void setWorkers(List<WorkSlot> workers) {
this.workers = workers;
}
+ @Override
+ public boolean equals(Object other) {
+ if (this == other) {
--- End diff --
Should check NPE?
> StreamRouterSpec class should override equals method
> -----------------------------------------------------
>
> Key: EAGLE-484
> URL: https://issues.apache.org/jira/browse/EAGLE-484
> Project: Eagle
> Issue Type: Bug
> Affects Versions: v0.5.0
> Reporter: JiJun Tang
> Assignee: JiJun Tang
> Fix For: v0.5.0
>
>
> {code:title=StreamRouterBolt.java|borderStyle=solid}
> if(!newSRS.get(s).equals(cachedSRS.get(s))){
> // this compare will get wrong result ,so will return wrong
> modifiedRouterSpecs
> modifiedRouterSpecs.add(newSRS.get(s));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
