[
https://issues.apache.org/jira/browse/EAGLE-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436551#comment-15436551
]
ASF GitHub Bot commented on EAGLE-500:
--------------------------------------
Github user haoch commented on the issue:
https://github.com/apache/incubator-eagle/pull/387
LGTM, pls merge.
> inaccurate IllegalStateException not caught within unit-test-cases when
> MongoDB normal stop() fails
> ---------------------------------------------------------------------------------------------------
>
> Key: EAGLE-500
> URL: https://issues.apache.org/jira/browse/EAGLE-500
> Project: Eagle
> Issue Type: Bug
> Reporter: Michael Wu
> Assignee: Michael Wu
>
> Looking at stopOrDestroyProcess() and waitForProcessGotKilled() methods of
> de.flapdoodle.embed.process.runtime.ProcessControl.java, when the returnCode
> returns from stopOrDestroyProcess() with "null", the process should have been
> destroyed by a native method implementation.
> So, the IllegalStateException thrown from waitForProcessGotKilled() seem not
> very accurate because it doesn't reflect the state of destroying result.
> To avoid false failure led by this issue in unit-test-case teardown(), I'd
> try catching the IllegalStateException when calling stop() of the
> MongodProcess instance, and filter the exception message "Couldn't kill .+
> process!".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
