[
https://issues.apache.org/jira/browse/EAGLE-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15559156#comment-15559156
]
ASF GitHub Bot commented on EAGLE-570:
--------------------------------------
GitHub user mizeng opened a pull request:
https://github.com/apache/incubator-eagle/pull/479
EAGLE-570: Refactor to make sure alert engine publisher only have gen…
Eagle-567 intend to provide better formatting of slack channel message. But
the implementation introduce too much specific logic (like defined field names)
that beyond a common alerting engine should have.
So need to refactor to move the specific logic to either vendor specific
extension or have configurable formatting.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mizeng/incubator-eagle master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/479.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #479
----
commit 83595c67848c4f43496251a6094705b427043198
Author: mizeng <[email protected]>
Date: 2016-10-09T03:09:37Z
EAGLE-570: Refactor to make sure alert engine publisher only have general
feature
----
> Refactor: Make sure engine publisher only have general feature.
> ---------------------------------------------------------------
>
> Key: EAGLE-570
> URL: https://issues.apache.org/jira/browse/EAGLE-570
> Project: Eagle
> Issue Type: Sub-task
> Affects Versions: v0.5.0
> Reporter: Su Ralph
> Assignee: Zeng, Bryant
> Fix For: v0.5.0
>
>
> Eagle-567 intend to provide better formatting of slack channel message. But
> the implementation introduce too much specific logic that beyond a common
> alerting engine should have.
> Need to refactor to move the specific logic to either vendor specific
> extension or have configurable formatting.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
