[
https://issues.apache.org/jira/browse/EAGLE-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561345#comment-15561345
]
ASF GitHub Bot commented on EAGLE-593:
--------------------------------------
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/481#discussion_r82543907
--- Diff:
eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/environment/impl/StormSubmitter.java
---
@@ -0,0 +1,317 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.eagle.app.environment.impl;
+import java.io.File;
+import java.nio.ByteBuffer;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.apache.commons.lang.StringUtils;
+import org.json.simple.JSONValue;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import backtype.storm.generated.AlreadyAliveException;
+import backtype.storm.generated.ClusterSummary;
+import backtype.storm.generated.InvalidTopologyException;
+import backtype.storm.generated.Nimbus;
+import backtype.storm.generated.StormTopology;
+import backtype.storm.generated.SubmitOptions;
+import backtype.storm.generated.TopologySummary;
+import backtype.storm.utils.BufferFileInputStream;
+import backtype.storm.utils.NimbusClient;
+import backtype.storm.utils.Utils;
+import backtype.storm.Config;
+
+/**
+ * copy from storm StormSubmitter
+ * just rewrite StormSubmitter that does not support summit other jars
once submittedJar is set.
+ * Our implementation will not add this restrict.
+ */
+
--- End diff --
Keep original comments
> Eagle Topology assembly multi-version Hadoop support & bug fix
> --------------------------------------------------------------
>
> Key: EAGLE-593
> URL: https://issues.apache.org/jira/browse/EAGLE-593
> Project: Eagle
> Issue Type: Improvement
> Reporter: wujinhu
> Assignee: wujinhu
>
> 1. User may want to support different version of hadoop in eagle jpm when
> uses topology asembly to be a final package. For this requirement, we add
> profiles to eagle-topology-assembly pom.xml. In this pom, we could add
> different versions of Hadoop.
> 2. Fix StormSubmitter does not support submit another jar
> In storm StormSubmitter
> ----------------------------------------------------------------------------------------------
> private static String submittedJar = null;
> private static void submitJar(Map conf, ProgressListener listener) {
> if(submittedJar==null) {
> LOG.info("Jar not uploaded to master yet. Submitting jar...");
> String localJar = System.getProperty("storm.jar");
> submittedJar = submitJar(conf, localJar, listener);
> } else {
> LOG.info("Jar already uploaded to master. Not submitting jar.");
> }
> }
> ----------------------------------------------------------------------------------------------
> It can not submit another jar once submittedJar is set.
> So I rewrote this class.
> 3. Fix MR Running Job that does not set finished jobs' state
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
