[ 
https://issues.apache.org/jira/browse/EAGLE-621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15579994#comment-15579994
 ] 

ASF GitHub Bot commented on EAGLE-621:
--------------------------------------

GitHub user anyway1021 opened a pull request:

    https://github.com/apache/incubator-eagle/pull/514

    [EAGLE-621] set authentication disabled by default when no 'auth' is 
configured

    Authentication settings are configured in configuration.yml file, starting 
with "auth" syntax. Now make the system see authentication as disabled when no 
auth related syntax is set.
    
    Also, do some refactoring to make the code clearer.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anyway1021/incubator-eagle EAGLE-621

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-eagle/pull/514.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #514
    
----
commit 377aaff0c2a70013427553fbab27153cf6b80afb
Author: anyway1021 <m...@apache.org>
Date:   2016-10-16T13:32:05Z

    set authentication disabled by default when no 'auth' is configured in 
configuration.yml

----


> set authentication disabled by default when no 'auth' is configured in 
> configuration.yml
> ----------------------------------------------------------------------------------------
>
>                 Key: EAGLE-621
>                 URL: https://issues.apache.org/jira/browse/EAGLE-621
>             Project: Eagle
>          Issue Type: Task
>            Reporter: Michael Wu
>            Assignee: Michael Wu
>
> Eagle's authentication configuration is set in config file, and we need to 
> set auth-service as disabled by default, especially when there is no 'auth' 
> and descendant param set.
> Also this may affect auth registration code structure, it need refactoring.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to