Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/550#discussion_r84570146
--- Diff:
eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/service/ApplicationAction.java
---
@@ -70,13 +71,16 @@ public ApplicationAction(Application application,
ApplicationEntity metadata, Co
this.application = application;
this.metadata = metadata;
this.runtime =
ExecutionRuntimeManager.getInstance().getRuntime(application.getEnvironmentType(),
serverConfig);
- Map<String, Object> executionConfig = metadata.getConfiguration();
+ Map<String, Object> executionConfig = new
HashMap<>(metadata.getConfiguration());
if (executionConfig == null) {
executionConfig = Collections.emptyMap();
}
if (serverConfig.hasPath(MetricConfigs.METRIC_PREFIX_CONF)) {
LOG.warn("Ignored sever config {} = {}",
MetricConfigs.METRIC_PREFIX_CONF,
serverConfig.getString(MetricConfigs.METRIC_PREFIX_CONF));
}
+
+ executionConfig.put("jarPath", metadata.getJarPath());
+ executionConfig.put("mode", metadata.getMode().name());
--- End diff --
It may cause the jarPath added into configuration when installating, I
think you should add only in `start` action.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
