Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/570#discussion_r86067948
--- Diff:
eagle-topology-check/eagle-topology-app/src/main/java/org/apache/eagle/topology/TopologyCheckApp.java
---
@@ -20,20 +20,38 @@
import backtype.storm.generated.StormTopology;
import backtype.storm.topology.TopologyBuilder;
+
+import com.microsoft.azure.storage.core.Logger;
import com.typesafe.config.Config;
+
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
import org.apache.eagle.app.StormApplication;
import org.apache.eagle.app.environment.impl.StormEnvironment;
+import org.apache.eagle.app.sink.StormStreamSink;
+import org.apache.eagle.topology.storm.HealthCheckParseBolt;
import org.apache.eagle.topology.storm.TopologyCheckAppSpout;
import org.apache.eagle.topology.storm.TopologyDataPersistBolt;
public class TopologyCheckApp extends StormApplication {
+ /**
+ *
+ */
+ private static final long serialVersionUID = 1L;
+
+ private static final String SINK_TASK_NUM = "topology.numOfSinkTasks";
+ private static final String TOPOLOGY_HEALTH_CHECK_STREAM =
"topology_health_check_stream";
+ Log logger = LogFactory.getLog(TopologyCheckApp.class);
--- End diff --
Use `private static final Logger LOG` for logger things.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
