[
https://issues.apache.org/jira/browse/EAGLE-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15627530#comment-15627530
]
ASF GitHub Bot commented on EAGLE-690:
--------------------------------------
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/570#discussion_r86067948
--- Diff:
eagle-topology-check/eagle-topology-app/src/main/java/org/apache/eagle/topology/TopologyCheckApp.java
---
@@ -20,20 +20,38 @@
import backtype.storm.generated.StormTopology;
import backtype.storm.topology.TopologyBuilder;
+
+import com.microsoft.azure.storage.core.Logger;
import com.typesafe.config.Config;
+
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
import org.apache.eagle.app.StormApplication;
import org.apache.eagle.app.environment.impl.StormEnvironment;
+import org.apache.eagle.app.sink.StormStreamSink;
+import org.apache.eagle.topology.storm.HealthCheckParseBolt;
import org.apache.eagle.topology.storm.TopologyCheckAppSpout;
import org.apache.eagle.topology.storm.TopologyDataPersistBolt;
public class TopologyCheckApp extends StormApplication {
+ /**
+ *
+ */
+ private static final long serialVersionUID = 1L;
+
+ private static final String SINK_TASK_NUM = "topology.numOfSinkTasks";
+ private static final String TOPOLOGY_HEALTH_CHECK_STREAM =
"topology_health_check_stream";
+ Log logger = LogFactory.getLog(TopologyCheckApp.class);
--- End diff --
Use `private static final Logger LOG` for logger things.
> Integrate topology health check with alert engine
> -------------------------------------------------
>
> Key: EAGLE-690
> URL: https://issues.apache.org/jira/browse/EAGLE-690
> Project: Eagle
> Issue Type: New Feature
> Affects Versions: v0.5.0
> Reporter: yupu
> Assignee: yupu
> Labels: features
> Fix For: v0.5.0
>
>
> Integrate topology health check with alert engine.
> It will send timestamp,tag,status to alert engine,when the node status is
> dead, alert engine will send the email to user
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
