Github user wujinhu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/612#discussion_r86709972
--- Diff:
eagle-jpm/eagle-jpm-util/src/main/java/org/apache/eagle/jpm/util/JobNameNormalization.java
---
@@ -64,7 +67,7 @@ private JobNameNormalization() {
// load normalization rules
Config conf = ConfigFactory.load();
--- End diff --
Please remove this line(Config conf = ConfigFactory.load();) from code.
Since our application is a storm topology, it will be better if we pass
configure to it when we initialize it so that it won't load dynamically.
Please do a simple refactor and just pass Config object to this class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
