[ 
https://issues.apache.org/jira/browse/EAGLE-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15653004#comment-15653004
 ] 

ASF GitHub Bot commented on EAGLE-643:
--------------------------------------

Github user haoch commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/606#discussion_r87327457
  
    --- Diff: 
eagle-security/eagle-security-oozie-auditlog/src/main/resources/META-INF/providers/org.apache.eagle.security.oozie.parse.OozieAuditLogAppProvider.xml
 ---
    @@ -0,0 +1,250 @@
    +<?xml version="1.0" encoding="UTF-8" ?>
    +<!--
    +  ~ Licensed to the Apache Software Foundation (ASF) under one or more
    +  ~ contributor license agreements.  See the NOTICE file distributed with
    +  ~ this work for additional information regarding copyright ownership.
    +  ~ The ASF licenses this file to You under the Apache License, Version 2.0
    +  ~ (the "License"); you may not use this file except in compliance with
    +  ~ the License.  You may obtain a copy of the License at
    +  ~
    +  ~    http://www.apache.org/licenses/LICENSE-2.0
    +  ~
    +  ~ Unless required by applicable law or agreed to in writing, software
    +  ~ distributed under the License is distributed on an "AS IS" BASIS,
    +  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
    +  ~ See the License for the specific language governing permissions and
    +  ~ limitations under the License.
    +  -->
    +
    +<application>
    +    <type>OOZIE_AUDIT_LOG_MONITOR</type>
    +    <name>Oozie Audit Log Monitor</name>
    +    <version>0.5.0-incubating</version>
    +    
<appClass>org.apache.eagle.security.oozie.parse.OozieAuditLogApplication</appClass>
    +    <configuration>
    +        <!-- topology related configurations -->
    +        <property>
    +            <name>workers</name>
    +            <displayName>workers</displayName>
    +            <value>1</value>
    +            <description>number of topology workers</description>
    +        </property>
    +        <property>
    +            <name>topology.numOfJoinTasks</name>
    +            <displayName>topology.numOfJoinTasks</displayName>
    --- End diff --
    
    Please change `displayName` of all properties in configuration descriptor 
to **human-readable name**, for example:  topology.numOfJoinTasks -> "Join 
Tasks Num"



> Implement oozieAuditLogAppProvider
> ----------------------------------
>
>                 Key: EAGLE-643
>                 URL: https://issues.apache.org/jira/browse/EAGLE-643
>             Project: Eagle
>          Issue Type: New Feature
>            Reporter: JiJun Tang
>            Assignee: Lingang Deng
>            Priority: Minor
>             Fix For: v0.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to