Looks good to me. +1 Zhang Wenli http://zhangwenli.com
On Thu, May 10, 2018 at 10:45 AM, 李木子 <annong...@gmail.com> wrote: > It's look good to me and I am a +1. > > 2018-05-10 5:46 GMT+08:00 Kevin A. McGrail <kmcgr...@apache.org>: > > > It's a marked improvement and I am a +1. > > > > On Wed, May 9, 2018, 09:22 沈毅 <shenyi....@gmail.com> wrote: > > > > > +1 > > > > > > checked: > > > - distribution files are correct. > > > - No files missing license. > > > - Files using d3 and zrender are included in LICENSE. > > > - MD5 is correct. > > > - DISCLAIMER is included. > > > - NOTICE is correct. > > > > > > SHUANG SU <sushuang0...@gmail.com> 于2018年5月8日周二 上午2:10写道： > > > > > > > I am pleased to be calling this vote for the release of Apache > ECharts > > > > 4.1.0.rc3. > > > > > > > > The release candidate to be voted over is available at: > > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.1.0.rc3/ > > > > > > > > The release candidate is signed with a GPG key available at: > > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS > > > > > > > > A tagged git repository is available for review at: > > > > https://github.com/apache/incubator-echarts/releases/tag/4.1.0.rc3 > > > > > > > > The Git commit for this release is: > > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=incubator-echarts. > > git;a=commit;h=f98eb21 > > > > > > > > The Release Note is available in: > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4. > > 1.0.rc3/RELEASE_NOTE.txt > > > > > > > > Some shell commmands for validating the release: > > > > > > > > ```shell > > > > # Download the release: > > > > curl > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4. > > 1.0.rc3/apache-echarts-4.1.0.rc3-incubating.zip > > > > -o apache-echarts-4.1.0.rc3-incubating.zip > > > > unzip apache-echarts-4.1.0.rc3-incubating.zip -d > > > > apache-echarts-4.1.0.rc3-incubating > /dev/null > > > > > > > > # Rebuild the project: > > > > cd "apache-echarts-4.1.0.rc3-incubating" && npm install && cd .. > > > > node "apache-echarts-4.1.0.rc3-incubating/build/build.js" --release > > > > # (See help: `node "apache-echarts-4.1.0.rc3- > > incubating/build/build.js" > > > > --help`) > > > > > > > > # Run Apache Rat: > > > > java -jar "apache-echarts-4.1.0.rc3-incubating/build/rat/runrat.jar" > | > > > less > > > > # (See help: `java -jar > > > > "apache-echarts-4.1.0.rc3-incubating/build/rat/runrat.jar" --help`) > > > > ``` > > > > > > > > > > > > Please vote on releasing this package as: > > > > Apache ECharts 4.1.0.rc3 > > > > > > > > This vote will be open until "2018-05-10T19:03:22.908Z" and passes > if a > > > > majority > > > > of at least three +1 Apache ECharts IPMC votes are cast. > > > > > > > > [ ] +1 Release this package > > > > [ ] 0 I don't feel strongly about it, but don't object > > > > [ ] -1 Do not release this package because... > > > > > > > > Anyone can participate in testing and voting, not just committers, > > please > > > > feel free to try out the release candidate and provide your votes. > > > > > > > > > > > > ------------------------------ > > > > Su Shuang (100pah) > > > > ------------------------------ > > > > > > > > > > > > > -- > > > Yi Shen > > > Senior Developer > > > Baidu, Inc. > > > > > >
