Ovilia commented on a change in pull request #9171: fix #8009 & #5969, symbol
symbolSize and opacity setting for category itemStyle in graph
URL: https://github.com/apache/incubator-echarts/pull/9171#discussion_r224354806
##########
File path: src/chart/graph/categoryVisual.js
##########
@@ -36,32 +36,19 @@ export default function (ecModel) {
var color = itemModel.get('itemStyle.color')
|| seriesModel.getColorFromPalette(name, paletteScope);
categoriesData.setItemVisual(idx, 'color', color);
+
var opacity = itemModel.get('itemStyle.opacity') || 1;
categoriesData.setItemVisual(idx, 'opacity', opacity);
- var itemSymbolType = itemModel.getShallow('symbol', true);
- if (itemSymbolType != null) {
- categoriesData.setItemVisual(idx, 'symbol', itemSymbolType);
- }
- var itemSymbolSize = itemModel.getShallow('symbolSize', true);
- if (itemSymbolSize != null) {
- categoriesData.setItemVisual(idx, 'symbolSize',
itemSymbolSize);
- }
+ var symbolStyleList =
['symbol','symbolSize','symbolKeepAspect','symbolOffset','symbolRotate']
- var itemSymbolKeepAspect =
itemModel.getShallow('symbolKeepAspect',true);
- if (itemSymbolKeepAspect != null) {
- categoriesData.setItemVisual(idx, 'symbolKeepAspect',
itemSymbolKeepAspect);
- }
-
- var itemSymbolOffset = itemModel.getShallow('symbolOffset',true);
- if (itemSymbolOffset != null) {
- categoriesData.setItemVisual(idx, 'symbolOffset',
itemSymbolOffset);
+ for(var i = 0;i < symbolStyleList.length;i++){
+ var symbolStyleItem = itemModel.getShallow(symbolStyleList[i],
true);
Review comment:
Did you test `graph-symbol.html`? It seems
`itemModel.getShallow('symbolOffset', true)` always return undefined, so that
`symbolOffset: ['30%', 0]` is config is not used. This doesn't seem right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
