100pah commented on a change in pull request #8997: Pie chart adds filterValue
parameter
URL: https://github.com/apache/incubator-echarts/pull/8997#discussion_r225535214
##########
File path: src/chart/pie/PieView.js
##########
@@ -211,7 +211,20 @@ piePieceProto.updateData = function (data, idx,
firstCreate) {
graphic.setHoverStyle(this);
};
-piePieceProto._updateLabel = function (data, idx) {
+piePieceProto._getFilterIgnore = function(data, idx) {
+ var seriesModel = data.hostModel;
+ var itemModel = data.getItemModel(idx);
+ var valueDim = data.mapDimension('value');
+ var sum = data.getSum(valueDim);
Review comment:
The `sum` is not necessary to be calculated in each iteration of the loop.
Only calculate it once outside the loop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
