100pah commented on a change in pull request #10129: fix bug #9704
URL:
https://github.com/apache/incubator-echarts/pull/10129#discussion_r266781399
##########
File path: src/model/mixin/lineStyle.js
##########
@@ -46,7 +46,7 @@ export default {
var lineType = this.get('type');
var dotSize = Math.max(lineWidth, 2);
var dashSize = lineWidth * 4;
- return (lineType === 'solid' || lineType == null) ? null
Review comment:
According to
<https://github.com/ecomfe/zrender/blob/master/src/graphic/Path.js#L136>
I think default value should better not be a `[0, 0]`, but still `null` is
better.
For this issue, probably we can always set a value to `style.lineDash` in
method `getLineStyle` above whether line dash is `null` or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
