Ovilia commented on a change in pull request #10295: Add aria defaults for
lang-en
URL:
https://github.com/apache/incubator-echarts/pull/10295#discussion_r275644324
##########
File path: src/langEN.js
##########
@@ -55,5 +55,37 @@ export default {
title: 'Save as Image',
lang: ['Right Click to Save Image']
}
+ },
+ aria: {
+ general: {
+ withTitle: 'This is a chart about "{title}"',
+ withoutTitle: 'This is a chart，'
Review comment:
Should use `,` instead of `，`.
Please also check other places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
