mixonic opened a new issue #10478: "Can't get dom width or height" incorrectly fires for width/height values of 0. URL: https://github.com/apache/incubator-echarts/issues/10478 ### Version 4.2.1 ### Steps to reproduce This warning from echarts: https://github.com/apache/incubator-echarts/blob/b6ab21159617b45c8077d998d468977cdd87d146/src/echarts.js#L1999 seems to be triggered when `!dom.clientWidth`, however I believe it is valid for `dom.clientWidth` to have a value of `0`. I'm not sure why this warning was added, but I think the check should be `dom.clientWidth === undefined` if the check is for a failure of the `clientWidth` API to exist. ### What is expected? warning should not occur for element width/height of 0 ### What is actually happening? warning is logged. --- I'm happy to resolve this issue, but I'd like some confirmation my hunch is correct, or a clarification for why it is not. <!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE --> <!-- This issue is in English. DO NOT REMOVE -->
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
