mixonic commented on issue #10478: "Can't get dom width or height" incorrectly fires for width/height values of 0. URL: https://github.com/apache/incubator-echarts/issues/10478#issuecomment-494004109 @Ovilia A relative sized `<div>` may be `0` pixels in height before the chart is rendered inside inside of it. That is the case I'm getting the warning for. > The warning here is to warn users that the chart is not visible most likely because the container doesn't have width or height The warning is specifically `Can't get dom width or height`. I *think* the original intent was to warn that a value could not be read at all, not that the chart might be invisible. For example the element in question could also be outside the screen, be visibility hidden, or display none and those things are not checked for. But I'm not sure about original intent. Some history: * Added in: https://github.com/apache/incubator-echarts/commit/303140d5e7626dd58b10528df6222ed2a671a6cf#diff-4258186c56ec56760534e2b465bf3f81R1084 * Bug reported wrt: https://github.com/apache/incubator-echarts/issues/4569 And afaict IE6 has support for `clientHeight` so I don't think it is an IE hack.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
