susiwen8 commented on a change in pull request #10503: Fix stack in markline
don't work
URL:
https://github.com/apache/incubator-echarts/pull/10503#discussion_r285940382
##########
File path: src/component/marker/MarkLineView.js
##########
@@ -44,14 +44,14 @@ var markLineTransform = function (seriesModel, coordSys,
mlModel, item) {
var value;
if (item.yAxis != null || item.xAxis != null) {
- valueDataDim = item.yAxis != null ? 'y' : 'x';
+ valueDataDim = seriesModel.get('stack') != null ?
'_\0ecstackresult' : item.yAxis != null ? 'y' : 'x';
Review comment:
Also, why using '__\0ecstackresult' not just '__ecstackresult'?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
