100pah commented on a change in pull request #10635: Set progressiveThreshold
and hoverLayerThreshold to Infinity
URL:
https://github.com/apache/incubator-echarts/pull/10635#discussion_r291879232
##########
File path: src/model/globalDefault.js
##########
@@ -67,15 +67,15 @@ export default {
animationThreshold: 2000,
// Configuration for progressive/incremental rendering
- progressiveThreshold: 3000,
+ progressiveThreshold: Infinity,
progressive: 400,
// Threshold of if use single hover layer to optimize.
// It is recommended that `hoverLayerThreshold` is equivalent to or less
than
// `progressiveThreshold`, otherwise hover will cause restart of
progressive,
// which is unexpected.
// see example <echarts/test/heatmap-large.html>.
- hoverLayerThreshold: 3000,
+ hoverLayerThreshold: Infinity,
Review comment:
I think The default hoverLayerThreshold should not be simply set Infinity.
I think we should find a better solution in `updateHoverLayerStatus`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
