Ovilia commented on a change in pull request #8513: avoid pie chart's label out
of range
URL: https://github.com/apache/incubator-echarts/pull/8513#discussion_r309523570
##########
File path: src/chart/pie/labelLayout.js
##########
@@ -28,18 +28,20 @@ function adjustSingleSide(list, cx, cy, r, dir, viewWidth,
viewHeight) {
// 压
function shiftDown(start, end, delta, dir) {
+ // 防止边缘出界
+ var couldShiftUp = (list[0].y - delta / 2) >= list[0].height * 0.61;
Review comment:
What does 0.61 mean?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
