My vote is -1(binding) Found unexpected node_modules folder in the release.
Checked: 1. Can build from source code. 2. DISCLAIMER, NOTICE, LICENSE files exists. 3. Year in NOTICE file is correct. 4. License is correct. On Mon, Sep 2, 2019 at 11:45 AM SHUANG SU <sushuang0...@gmail.com> wrote: > I am pleased to be calling this vote for the release of Apache ECharts > (incubating) 4.3.0 (release candidate 1). > > The release candidate to be voted over is available at: > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.3.0-rc.1/ > > The release candidate is signed with a GPG key available at: > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS > > The Git commit for this release is: > > https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=b62ab99 > > The Release Note is available in: > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.3.0-rc.1/RELEASE_NOTE.txt > > Some shell commands for validating the release: > > ```shell > # Download the release: > curl > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.3.0-rc.1/apache-echarts-4.3.0-rc.1-incubating-src.zip > -o apache-echarts-4.3.0-rc.1-incubating-src.zip > unzip apache-echarts-4.3.0-rc.1-incubating-src.zip -d > apache-echarts-4.3.0-rc.1-incubating-src > /dev/null > > # Build the project (Node.js environment is required): > cd "apache-echarts-4.3.0-rc.1-incubating-src" && npm install && cd .. > node "apache-echarts-4.3.0-rc.1-incubating-src/build/build.js" --release > # (See help: `node > "apache-echarts-4.3.0-rc.1-incubating-src/build/build.js" --help`) > ``` > > > Please vote on releasing this package as: > Apache ECharts (incubating) 4.3.0 (release candidate 1) > by "2019-09-05T04:28:42.815Z". > > [ ] +1 Release this package > [ ] 0 I don't feel strongly about it, but don't object > [ ] -1 Do not release this package because... > > Anyone can participate in testing and voting, not just committers, please > feel free to try out the release candidate and provide your votes. > > > ------------------------------ > Su Shuang (100pah) > ------------------------------ > -- Yi Shen Senior Developer Baidu, Inc.
