Hi Dave, 1) We have build instructions in the README https://github.com/apache/incubator-echarts/blob/master/README.md#build But I checked the source release again and surprisingly found the README is not in it.
Shuang, I think we should include the README in the next release, or we can have an individual doc about how to build. 2) Some information in the doc https://echarts.apache.org/en/tutorial.html#Get%20Started%20with%20ECharts%20in%205%20minutes is outdated. We will update it ASAP. Thanks for the reminding. 3) About https://echarts.baidu.com/dist/echarts.min.js . We will remove this file since echarts.baidu.com will be not available. But I'm not sure how should we deal with the distribution files on the CDN like cloudflare or jsdelivr 4) We will open a JIRA ticket to ask about the GitHub release tag. Best regards. On Tue, Oct 1, 2019 at 2:38 AM Dave Fisher <w...@apache.org> wrote: > +1 (binding) - I have conditions listed below. > > Checked: > Incubating in name > Detached signature and checksum > NOTICE > LICENSE including license-D3 > DISCLAIMER > No unexpected binaries > RAT check > > (1) The English instructions are not clear on how to build. There are > options on > > https://echarts.apache.org/en/tutorial.html#Get%20Started%20with%20ECharts%20in%205%20minutes > But the links there are not proper - > (a) https://ecomfe.github.io/echarts-doc/public/en/download.html is a 404 > - it should point to the download page. > (b) https://echarts.baidu.com/dist/echarts.min.js - this is not a proper > Apache Release artifact > (c) https://github.com/apache/incubator-echarts/releases - this is not a > proper location for Apache Releases until permission is requested and > received from Apache Legal - we’ll need to start a LEGAL JIRA asking if > these can be accepted. It may not happen since I don’t think the GitHub > release tags are immutable. > (d) > https://ecomfe.github.io/echarts-doc/public/en/tutorial.html#Use%20ECharts%20with%20webpack > is a 404. This should be on the Apache ECharts website. > > (2) On this page: > https://echarts.apache.org/en/tutorial.html#Create%20Custom%20Build%20of%20ECharts > (a) the download page link is a 404. > (b) I don’t know enough to follow the further instructions. There are > options and I don’t which to pick. > > (3) The download page has guides the user into (1) above. > > I think that there are three action items: > (A) Fixing the links on en/tutorial.html along with improving the text. > (B) Create a LEGAL JIRA to make sure that the use of the Github.com > release tag meets requirements. > (C) Provide a prescriptive build instruction that allows new people and > your mentors better knowledge on how to build. > > After this release is approved we can discuss how to use > archive.apache.org for the older releases on the Download page. > > Regards, > Dave > > > On Sep 30, 2019, at 5:19 AM, SHUANG SU <sushuang0...@gmail.com> wrote: > > > > I am pleased to be calling this vote for the release of Apache ECharts > > (incubating) 4.4.0 (release candidate 1). > > > > The release candidate to be voted over is available at: > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.4.0-rc.1/ > > > > The release candidate is signed with a GPG key available at: > > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS > > > > The Git commit for this release is: > > > https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=b2b38d67 > > > > The Release Note is available in: > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.4.0-rc.1/RELEASE_NOTE.txt > > > > Some shell commands for validating the release: > > > > ```shell > > # Download the release: > > curl > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.4.0-rc.1/apache-echarts-4.4.0-rc.1-incubating-src.zip > > -o apache-echarts-4.4.0-rc.1-incubating-src.zip > > unzip apache-echarts-4.4.0-rc.1-incubating-src.zip -d > > apache-echarts-4.4.0-rc.1-incubating-src > /dev/null > > > > # Download and check the signatures (optional): > > curl > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.4.0-rc.1/apache-echarts-4.4.0-rc.1-incubating-src.zip.asc > > -o apache-echarts-4.4.0-rc.1-incubating-src.zip.asc > > curl > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.4.0-rc.1/apache-echarts-4.4.0-rc.1-incubating-src.zip.sha512 > > -o apache-echarts-4.4.0-rc.1-incubating-src.zip.sha512 > > # check asc > > gpg --verify apache-echarts-4.4.0-rc.1-incubating-src.zip.asc > > # check sha512 > > shasum -a 512 -c apache-echarts-4.4.0-rc.1-incubating-src.zip.sha512 > > > > # Build the project (Node.js environment is required): > > cd "apache-echarts-4.4.0-rc.1-incubating-src" && npm install > > npm run release > > # (See help: `node "build/build.js" --help`) > > ``` > > > > > > Please vote on releasing this package as: > > Apache ECharts (incubating) 4.4.0 (release candidate 1) > > by "2019-10-03T10:14:50.226Z". > > > > [ ] +1 Release this package > > [ ] 0 I don't feel strongly about it, but don't object > > [ ] -1 Do not release this package because... > > > > Anyone can participate in testing and voting, not just committers, please > > feel free to try out the release candidate and provide your votes. > > > > A checklist for reference: > > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > > > > Thanks, > > ------------------------------ > > Su Shuang (100pah) > > ------------------------------ > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org > For additional commands, e-mail: dev-h...@echarts.apache.org > > -- Yi Shen Senior Developer Baidu, Inc.
