I think we still need the package-lock.json to fix the dependencies in the release artifacts.
On Tue, Apr 13, 2021 at 10:47 AM Yi Shen <shenyi....@gmail.com> wrote: > I think it's because the installed typescript version 4.2.4 is not > compatible with tslib version 2.0.3. > We should either fix the typescript to 4.1.2 or upgrade tslib to 2.2.0. > > On Tue, Apr 13, 2021 at 10:30 AM Yi Shen <shenyi....@gmail.com> wrote: > >> I have this error when building from source: >> >> ./Users/lang/Downloads/apache-echarts-5.1.0-rc.1-src/src/coord/axisModelCreator.ts >>> (73,23): This syntax requires an imported helper named '__spreadArray' >>> which does not exist in 'tslib'. Consider upgrading your version of 'tslib'. >>> >> >> >> Checked others: >> >> >> - The release file is in the right location >> >> - Signature and hash are correct. >> >> - Version is correct in package.json >> >> - LICENSE and NOTICE file exist >> >> - NOTICE year correct >> >> >> Thanks >> >> On Mon, Apr 12, 2021 at 7:10 PM SHUANG SU <sushuang0...@gmail.com> wrote: >> >>> I am pleased to be calling this vote for the release of Apache ECharts >>> 5.1.0 (release candidate 1). >>> >>> The release candidate to be voted over is available at: >>> https://dist.apache.org/repos/dist/dev/echarts/5.1.0-rc.1/ >>> >>> The release candidate is signed with a GPG key available at: >>> https://dist.apache.org/repos/dist/dev/echarts/KEYS >>> >>> The Git commit for this release is: >>> https://gitbox.apache.org/repos/asf?p=echarts.git;a=commit;h=4628dd7 >>> >>> The Release Note is available in: >>> >>> https://dist.apache.org/repos/dist/dev/echarts/5.1.0-rc.1/RELEASE_NOTE.txt >>> >>> Build Guide: >>> https://github.com/apache/echarts/blob/5.1.0-rc.1/README.md#build >>> >>> Please vote on releasing this package as: >>> Apache ECharts 5.1.0 (release candidate 1) >>> by "2021-04-15T12:09:03.924Z". >>> >>> [ ] +1 Release this package >>> [ ] 0 I don't feel strongly about it, but don't object >>> [ ] -1 Do not release this package because... >>> >>> Anyone can participate in testing and voting, not just committers, please >>> feel free to try out the release candidate and provide your votes. >>> >>> >>> Thanks, >>> ------------------------------ >>> Su Shuang (100pah) >>> ------------------------------ >>> >> >> >> -- >> Yi Shen >> Apache ECharts(incubating) PMC >> > > > -- > Yi Shen > Apache ECharts(incubating) PMC > -- Yi Shen Apache ECharts(incubating) PMC
