+1 binding

Checked:


- The release file is in the right location

- Signature and hash are correct.

- Version is correct in package.json

- Can build from source.

- Can run the example with the build file.

- LICENSE and NOTICE files exist

- NOTICE year correct


Regards.

On Tue, Mar 21, 2023 at 1:32 AM Zhongxiang Wang <wan...@apache.org> wrote:

> +1 (binding)
>
> Checked as follows,
>
> - The release files are in the right place
> - GPG signature verified and SHASUM is correct
> - Version is correct in package.json & package-lock.json (5.4.2)
> - LICENSE and NOTICE exist
> - The year in NOTICE is correct (2023)
> - RELEASE_NOTE.txt is correct (with version 5.4.2)
> - Can build from the source code (via `npm run release`)
> - `test/check-build.html` works well with built files
>
> Thanks for your work :)
>
>
> On Fri, Mar 17, 2023 at 2:27 PM zakwu <za...@apache.org> wrote:
>
> >
> >
> >
> > Dear community,
> >
> >
> >
> >
> > We are pleased to be calling this vote for the release of Apache ECharts
> > 5.4.2 (release candidate 1).
> >
> >
> >
> >
> > The release candidate to be voted over is available at:
> >
> > https://dist.apache.org/repos/dist/dev/echarts/5.4.2-rc.1/
> >
> >
> >
> >
> > The release candidate is signed with a GPG key available at:
> >
> > https://dist.apache.org/repos/dist/dev/echarts/KEYS
> >
> >
> >
> >
> > The Git commit for this release is:
> >
> >
> >
> https://gitbox.apache.org/repos/asf?p=echarts.git;a=commit;h=cfb3a8a544440588d0d51a2cf622f340f0d6ebd8
> >
> >
> >
> >
> > The Release Note is available in:
> >
> >
> https://dist.apache.org/repos/dist/dev/echarts/5.4.2-rc.1/RELEASE_NOTE.txt
> >
> >
> >
> >
> > Build Guide:
> >
> > https://github.com/apache/echarts/blob/5.4.2-rc.1/README.md#build
> >
> >
> >
> >
> > NPM Install:
> >
> > npm i echarts@5.4.2-rc.1
> >
> > https://www.npmjs.com/package/echarts/v/5.4.2-rc.1
> >
> >
> >
> >
> > Please vote on releasing this package as:
> >
> > Apache ECharts 5.4.2 (release candidate 1)
> >
> > by "2023-03-20T06:23:07.785Z".
> >
> >
> >
> >
> > [ ] +1 Release this package
> >
> > [ ] 0 I don't feel strongly about it, but don't object
> >
> > [ ] -1 Do not release this package because...
> >
> >
> >
> >
> > Anyone can participate in testing and voting, not just committers, please
> >
> > feel free to try out the release candidate and provide your votes.
> >
> >
> >
> >
> > A checklist for reference:
> >
> >
> >
> https://cwiki.apache.org/confluence/display/ECHARTS/Apache+ECharts+Release+Checklist
> >
> >
> > Thanks!
>


-- 
Yi Shen
Apache ECharts PMC

Reply via email to