> - The source code is the same as the GitHub tag "5.1.1-rc.1".
Edit:
- The source code is the same as the GitHub tag "5.4.3".
Sorry made the mistake.
Thanks,
------------------------------
Su Shuang (100pah)
------------------------------
On Mon, 17 Jul 2023 at 18:09, Zhongxiang Wang <wan...@apache.org> wrote:
> +1 (binding)
>
> Checked as follows,
>
> - The release files are in the right place
> - GPG signature verified and SHASUM is correct
> - Version is correct in package.json & package-lock.json (5.4.3)
> - LICENSE and NOTICE exist
> - The year in NOTICE is correct (2023)
> - RELEASE_NOTE.txt is correct (with version 5.4.3)
> - Can build from the source code (via `npm run release`)
> - `test/check-build.html` works well with dist files
>
> Thanks for your work!
>
> On Mon, Jul 17, 2023 at 2:15 PM SHUANG SU <sushuang0...@gmail.com> wrote:
>
> > +1 (binding)
> >
> > I checked:
> > - The release file is in the right location
> > - sha512 and asc is correct.
> > - Version is correct in package.json and src/core/echarts.ts
> > - The source code is the same as the GitHub tag "5.1.1-rc.1".
> > - LICENSE is correct.
> > - RELEASE_NOTE exists and is correct.
> > - Download and npm install and build OK.
> > - Can run examples from build.
> >
> > Thanks,
> > ------------------------------
> > Su Shuang (100pah)
> > ------------------------------
> >
> >
> >
> > On Mon, 17 Jul 2023 at 12:31, Ovilia <oviliazh...@gmail.com> wrote:
> >
> > > +1
> > >
> > > I checked:
> > >
> > > - The release file is in the right location
> > >
> > > - Signature and hash are correct
> > >
> > > - Version is correct in package.json
> > >
> > > - LICENSE and NOTICE file exist
> > >
> > > - NOTICE year correct
> > >
> > > - RELEASE_NOTE.txt is correct
> > >
> > > - Can build from source.
> > >
> > > Thanks
> > >
> > > *Ovilia*
> > >
> > >
> > > On Fri, Jul 14, 2023 at 4:44 PM hehao <he...@apache.org> wrote:
> > >
> > > > Dear community,
> > > > We are pleased to be calling this vote for the release of Apache
> > ECharts
> > > > 5.4.3 (release candidate 1).
> > > >
> > > > The release candidate to be voted over is available at:
> > > > https://dist.apache.org/repos/dist/dev/echarts/5.4.3-rc.1/
> > > >
> > > > The release candidate is signed with a GPG key available at:
> > > > https://dist.apache.org/repos/dist/dev/echarts/KEYS
> > > >
> > > > The Git commit for this release is:
> > > >
> > > >
> > >
> >
> https://gitbox.apache.org/repos/asf?p=echarts.git;a=commit;h=aaa8cf9048e82a2d4130ac3cae3a903bee92ffc2
> > > >
> > > > The Release Note is available in:
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/echarts/5.4.3-rc.1/RELEASE_NOTE.txt
> > > >
> > > > Build Guide:
> > > > https://github.com/apache/echarts/blob/5.4.3-rc.1/README.md#build
> > > >
> > > > NPM Install:
> > > > npm i echarts@5.4.3-rc.1
> > > > https://www.npmjs.com/package/echarts/v/5.4.3-rc.1
> > > >
> > > > Please vote on releasing this package as:
> > > > Apache ECharts 5.4.3 (release candidate 1)
> > > > by "2023-07-17T16:10:07.785Z".
> > > >
> > > > [ ] +1 Release this package
> > > > [ ] 0 I don't feel strongly about it, but don't object
> > > > [ ] -1 Do not release this package because...
> > > >
> > > > Anyone can participate in testing and voting, not just committers,
> > please
> > > > feel free to try out the release candidate and provide your votes.
> > > >
> > > > A checklist for reference:
> > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/ECHARTS/Apache+ECharts+Release+Checklist
> > > >
> > > > Thanks！
> > > >
> > >
> >
>
