-1 (binding)
Sorry I made a mistake in this commit:
https://github.com/apache/echarts/commit/abe29f0e76e93a9b662663832cf9a37a9310726a#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L110
Where the package.json exports should be:
"exports": {
".": {
"types": "./index.d.ts",
"import": "./index.js",
"require": "./dist/echarts.js"
},
rather than currently
"exports": {
".": {
"types": "./index.d.ts",
"import": "./index.js",
"require": "./index.js"
},
The latter one cause that `requre(echarts)` in nodejs does not work any
more (previous it works).
Sorry for that stupid mistake.
But I think it needs to be fixed a.s.a.p and re-publish the RC version.
Thanks,
------------------------------
Su Shuang (100pah)
------------------------------
On Wed, 31 Jan 2024 at 22:31, Zhongxiang Wang <wan...@apache.org> wrote:
> +1 (binding)
>
> Checked as follows,
>
> - The release files are in the right place
> - GPG signature is verified and SHASUM is correct
> - Version is correct in package.json & package-lock.json (5.5.0)
> - LICENSE and NOTICE exist
> - The year in NOTICE is correct (2024)
> - RELEASE_NOTE.txt is correct (with version 5.5.0)
> - Can build from the source code (via `npm run release`)
> - `test/check-build.html` works well with dist files
>
> Thanks for your work!
>
> On Wed, Jan 31, 2024 at 5:05 PM Ovilia <oviliazh...@gmail.com> wrote:
>
> > Dear community,
> >
> > We are pleased to be calling this vote for the release of Apache ECharts
> > 5.5.0 (release candidate 1).
> >
> > The release candidate to be voted over is available at:
> > https://dist.apache.org/repos/dist/dev/echarts/5.5.0-rc.1/
> >
> > The release candidate is signed with a GPG key available at:
> > https://dist.apache.org/repos/dist/dev/echarts/KEYS
> >
> > The Git commit for this release is:
> >
> >
> https://gitbox.apache.org/repos/asf?p=echarts.git;a=commit;h=4d3bbaefa53dd85ad730dbaa09805d7152019ea4
> >
> > The Release Note is available in:
> >
> https://dist.apache.org/repos/dist/dev/echarts/5.5.0-rc.1/RELEASE_NOTE.txt
> >
> > Build Guide:
> > https://github.com/apache/echarts/blob/5.5.0-rc.1/README.md#build
> >
> > NPM Install:
> > npm i echarts@5.5.0-rc.1
> > https://www.npmjs.com/package/echarts/v/5.5.0-rc.1
> >
> > Please vote on releasing this package as:
> > Apache ECharts 5.5.0 (release candidate 1)
> > by "2024-02-03T14:23:24.027Z".
> >
> > [ ] +1 Release this package
> > [ ] 0 I don't feel strongly about it, but don't object
> > [ ] -1 Do not release this package because...
> >
> > Anyone can participate in testing and voting, not just committers, please
> > feel free to try out the release candidate and provide your votes.
> >
> > A checklist for reference:
> >
> >
> https://cwiki.apache.org/confluence/display/ECHARTS/Apache+ECharts+Release+Checklist
> >
> > Thanks
> >
> > *Ovilia*
> >
>
