+1 binding
Checked: - The release file is in the right location - Version is correct in package.json - Can build from source. - Can run the example with the build file. Regards On Thu, Feb 8, 2024 at 2:57 PM Zhongxiang Wang <wan...@apache.org> wrote: > +1 (binding) > > Check List: > > - The release files are in the right place > - GPG signature is verified and SHASUM is correct > - Version is correct in package.json & package-lock.json (5.5.0) > - LICENSE and NOTICE exist > - The year in NOTICE is correct (2024) > - RELEASE_NOTE.txt is correct (with version 5.5.0) > - Can build from the source code (via `npm run release`) > - `test/check-build.html` works well with dist files > - Can require echarts in a commonjs file > > > On Thu, Feb 8, 2024 at 10:00 AM Ovilia <oviliazh...@gmail.com> wrote: > > > Thank you all for checking. > > Due to the Chinese New Year Festival, many of our PMC members are on > > vacation. We will wait for a few more days for this vote. > > > > Thanks > > > > *Ovilia* > > > > > > On Thu, Feb 8, 2024 at 3:37 AM Ville Brofeldt < > ville.v.brofe...@gmail.com> > > wrote: > > > > > Hi all, > > > > > > Thanks for working on this new release! I tested rc2 against master > > branch > > > of Superset, and it works great. The typing change from #19111 > identified > > > an issue where we were not handling the null or undefined > > OptionDataValue). > > > Other than that no issues, and the changes in the release notes look > > really > > > good. So +1 from me. > > > > > > Happy Lunar New Year and thanks again for all the hard work! > > > > > > Ville > > > > > > > > > > On Feb 7, 2024, at 5:35 AM, SHUANG SU <sushuang0...@gmail.com> > wrote: > > > > > > > > +1 (binding) > > > > > > > > > > > > I checked: > > > > - The release file is in the right location > > > > - sha512 and asc is correct. > > > > - Version is correct in package.json and src/core/echarts.ts > > > > - The source code is the same as the GitHub tag "5.5.0-rc.2". > > > > - LICENSE is correct. > > > > - RELEASE_NOTE exists and is correct. > > > > - Download and npm install and build OK. > > > > - Can run examples from build. > > > > > > > > > > > > > > > > Thanks, > > > > ------------------------------ > > > > Su Shuang (100pah) > > > > ------------------------------ > > > > > > > > > > > > > > > > On Sun, 4 Feb 2024 at 15:52, Ovilia <oviliazh...@gmail.com> wrote: > > > > > > > >> Dear community, > > > >> > > > >> We are pleased to be calling this vote for the release of Apache > > ECharts > > > >> 5.5.0 (release candidate 2). > > > >> > > > >> The release candidate to be voted over is available at: > > > >> https://dist.apache.org/repos/dist/dev/echarts/5.5.0-rc.2/ > > > >> > > > >> The release candidate is signed with a GPG key available at: > > > >> https://dist.apache.org/repos/dist/dev/echarts/KEYS > > > >> > > > >> The Git commit for this release is: > > > >> > > > >> > > > > > > https://gitbox.apache.org/repos/asf?p=echarts.git;a=commit;h=0f4967b1bdef6b35e795b9fb1403e765489649fa > > > >> > > > >> The Release Note is available in: > > > >> > > > > > > https://dist.apache.org/repos/dist/dev/echarts/5.5.0-rc.2/RELEASE_NOTE.txt > > > >> > > > >> Build Guide: > > > >> https://github.com/apache/echarts/blob/5.5.0-rc.2/README.md#build > > > >> > > > >> NPM Install: > > > >> npm i echarts@5.5.0-rc.2 > > > >> https://www.npmjs.com/package/echarts/v/5.5.0-rc.2 > > > >> > > > >> Please vote on releasing this package as: > > > >> Apache ECharts 5.5.0 (release candidate 2) > > > >> by "2024-02-07T19:22:36.911Z". > > > >> > > > >> [ ] +1 Release this package > > > >> [ ] 0 I don't feel strongly about it, but don't object > > > >> [ ] -1 Do not release this package because... > > > >> > > > >> Anyone can participate in testing and voting, not just committers, > > > please > > > >> feel free to try out the release candidate and provide your votes. > > > >> > > > >> A checklist for reference: > > > >> > > > >> > > > > > > https://cwiki.apache.org/confluence/display/ECHARTS/Apache+ECharts+Release+Checklist > > > >> > > > >> Thanks > > > >> > > > >> *Ovilia* > > > >> > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org > > > For additional commands, e-mail: dev-h...@echarts.apache.org > > > > > > > > > -- Yi Shen Apache ECharts PMC
