+1 binding

Checked:


- The release file is in the right location

- Signature and hash are correct.

- Version is correct in package.json

- Can build from source.

- Can run the example with the build file.

- LICENSE and NOTICE files exist

- NOTICE year correct

On Wed, Dec 25, 2024 at 3:16 AM SHUANG SU <sushuang0...@gmail.com> wrote:

> +1 (binding)
>
> I checked:
> - The release file is in the right location.
> - sha512 and asc is correct.
> - Version is correct in package.json and src/core/echarts.ts .
> - The source code is the same as the GitHub tag "5.6.0-rc.1".
> - The build result from the published source code is the same as npm
> "5.6.0-rc.1".
> - The diff from tag "5.6.0-rc.1" to the last tag is OK.
> - LICENSE is correct.
> - RELEASE_NOTE exists and is correct.
> - Download and npm install and build OK.
> - Can run examples from build.
>
> Thanks,
> ------------------------------
>  Su Shuang (100pah)
> ------------------------------
>
>
>
> On Mon, 23 Dec 2024 at 16:17, Ovilia <oviliazh...@gmail.com> wrote:
>
> > +1
> >
> > I checked:
> >
> > - The release file is in the right location
> >
> > - Signature and hash are correct
> >
> > - Version is correct in package.json
> >
> > - LICENSE and NOTICE file exist
> >
> > - NOTICE year correct
> >
> > - RELEASE_NOTE.txt is correct
> >
> > - Can build from source.
> >
> >
> >
> > Thanks
> >
> > *Ovilia*
> >
> >
> > On Sat, Dec 21, 2024 at 5:33 PM Zhongxiang Wang <wan...@apache.org>
> wrote:
> >
> > > Dear community,
> > >
> > > We are pleased to be calling this vote for the release of Apache
> ECharts
> > > 5.6.0 (release candidate 1).
> > >
> > > The release candidate to be voted over is available at:
> > > https://dist.apache.org/repos/dist/dev/echarts/5.6.0-rc.1/
> > >
> > > The release candidate is signed with a GPG key available at:
> > > https://dist.apache.org/repos/dist/dev/echarts/KEYS
> > >
> > > The Git commit for this release is:
> > >
> > >
> >
> https://gitbox.apache.org/repos/asf?p=echarts.git;a=commit;h=fe42bc1ea3a8d2ef7864cfe303de34f480149d09
> > >
> > > The Release Note is available in:
> > >
> >
> https://dist.apache.org/repos/dist/dev/echarts/5.6.0-rc.1/RELEASE_NOTE.txt
> > >
> > > Build Guide:
> > > https://github.com/apache/echarts/blob/5.6.0-rc.1/README.md#build
> > >
> > > NPM Install:
> > > npm i echarts@5.6.0-rc.1
> > > https://www.npmjs.com/package/echarts/v/5.6.0-rc.1
> > >
> > > Please vote on releasing this package as:
> > > Apache ECharts 5.6.0 (release candidate 1)
> > > by "2024-12-24T20:47:15.711Z".
> > >
> > > [ ] +1 Release this package
> > > [ ] 0 I don't feel strongly about it, but don't object
> > > [ ] -1 Do not release this package because...
> > >
> > > Anyone can participate in testing and voting, not just committers,
> please
> > > feel free to try out the release candidate and provide your votes.
> > >
> > > A checklist for reference:
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/ECHARTS/Apache+ECharts+Release+Checklist
> > >
> >
>


-- 
Yi Shen
Apache ECharts PMC

Reply via email to