Github user dlaboss commented on a diff in the pull request:
https://github.com/apache/incubator-edgent/pull/309#discussion_r127962743
--- Diff: pom.xml ---
@@ -223,6 +223,15 @@
</lifecycleMappingMetadata>
</configuration>
</plugin>
+
+ <!-- Inject the "incubating" into the output filename -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-assembly-plugin</artifactId>
+ <configuration>
+ <finalName>edgent-incubating-${project.version}</finalName>
--- End diff --
Makes sense, thanks. I also noticed that the current bundles have an
apache prefix ("apache-edgent-<ver>....tgz"). Don't recall if that's a best
practice, I seem to have a recollection of Justin noting something about it :-)
Your thoughts?
We also currently create .md5 and .sha files for distribution. Are they
missing or do they only get created as part of a different task (I used mvn
install -Papache-release)?
Previously we only created a tgz bundle. Now it looks like only a zip?
Seems OK but wanted to double check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
