Ok,
So, I just committed some changes that should now finally correctly generate he
correct NOTICE, LICENSE files.
I verified all of the modules (also the java7 and android ones) and they all
seemed to be correct now.
By the way … today is my last day working as a consultant for an outside
customer. Starting tomorrow I will be working
on my PLC research project for 100% of my working time and project this
includes a lot of Apache Edgent work :-)
Chris
Am 12.10.17, 10:24 schrieb "Christofer Dutz" <christofer.d...@c-ware.de>:
Hi Dale,
Great that you found the problems that were causing some troubles with
unintentionally included jars :-)
I invested another few days on finishing the licensing and cleaning it up
even more.
While on it I have come across two things:
1) If I specify the inceptionYear in the root pom, the copyright is
automatically output as a timespan in the NOTICE file so there is no need to
specify the non-ibm NOTICE version.
2) If I specify a appendedResourcesDirectory, I can add content that is
appended to the generated resources
Therefore I have reomoved all NOTICE and LICENSE files and added just the
parts that need to be appended, if something needs to be appended.
I guess I’ll finisch this tomorrow and then I’ll commit all changes. I
guess with this the build will be greatly simplified and we don’t need to add
duplicated files all over the place.
I also noticed the „platforms“ were missing a lot of the LICENSE and NOTICE
files and I will go through all modules to ensure they are in place with the
correct content.
Eventually we’ll finally be able to finish this legal document inferno soon
and we can get back to writing and improving great software :-)
Chris
Am 09.10.17, 20:49 schrieb "Dale LaBossiere" <dml.apa...@gmail.com>:
Hi Chris,
I reflected your last commit of “licensing changes” for the j8
distribution bundle to the j7 and android ones.
I also added the missing edgent-android-* jars to the android
distribution
There’s still one problem I noticed...
Both j7 and android distribution bundles have unexpected/undesired ext
jars: animal-sniffer-annotations, error-prone-annotations, j2objc-annotations,
guava, jar305. Sounds related to the additional checking that you added to
verify appropriate jar content for j7,android post retrolambda processing?
I’d clean this up if it was obvious to me why that was occurring and
how to address it, so can you please address that :-)
Thanks!
— Dale
