jan666 commented on code in PR #16: URL: https://github.com/apache/empire-db/pull/16#discussion_r1318374806
########## empire-db/src/test/java/org/apache/empire/commons/ObjectUtilsTest.java: ########## @@ -52,6 +53,21 @@ public void testIsEmpty() assertFalse(ObjectUtils.isEmpty(new Object())); } + @Test + public void testIsZero() + { + assertTrue(ObjectUtils.isZero(BigDecimal.ZERO)); + assertTrue(ObjectUtils.isZero(0f)); + assertTrue(ObjectUtils.isZero(Float.valueOf("0"))); + assertTrue(ObjectUtils.isZero(0d)); + assertTrue(ObjectUtils.isZero(0l)); + assertTrue(ObjectUtils.isZero(0)); + assertTrue(ObjectUtils.isZero(null)); Review Comment: please use tabs or spaces - not both -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@empire-db.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org