Hello Ralf, thanks für your pull request regarding updating the spring boot version.
Being able to filter tables for CodeGen sounds like a good idea. But then it should also be possible to exclude certain views. Generally you should always create a JiraTicket for such issues, so that we can track them. In your commit comment you should then always specify the JIRA ticket number e.g. "EMPIREDB-484" IMO first two properties are required in CodeGenConfig.java. To be consistent with the other properties, I would recommend to name them - tableExcludePattern - viewExcludePattern To my surprise I have found that there already is a property called "dbTablePattern". But it does not seem to be used anywhere. Hence I would recommend removing this property. Since you are a committer for Empire-db, there is no need to provide pull requests. You should be able to push directly to origin/master on " https://gitbox.apache.org/repos/asf/empire-db.git"; Best regards Rainer -----Original message----- from: Ralf Eichinger <[email protected]> to: [email protected] subject: exclude tables from CodeGenerator I am using maven plugin to generate code from existing database. there are tables from thirdparty software (flowable) starting with "ACT_" and "FLW_". I want to exclude them from generation. Currently this is not possible. But I think it would be easy to add a regex matching for configured exclusion pattern in CodeGenWriter.generateCodeFiles: // Create table classes, record interfaces and record classes for (DBTable table : db.getTables()) { if (table.getName().matches(config.getDbTablesExclusionPattern()) { continue; // skip the excluded table } if (!config.isNestTables()) { // if table nesting is disabled, create separate table classes generatedFiles.add(this.createTableClass(db, table)); } if (config.isGenerateRecords()) { // generate record generatedFiles.add(this.createRecordClass(db, table)); } } If you find this useful: Should I come up with a pull request or is creating a jira ticket first required?
