Yup :-) It's just hard to tell from the diff unless you do the diff at the top level of the subversion hierarchy. Last night I applied it to the branch and committed it (except the change that caused two tests to fail).
For the popstatsactor stuff we need to figure out why the behavior has changed. I also don't see why it has changed at first glance. Thanks again for putting together this patch! Ethan On Thursday, January 6, 2011, Vladimir Ivanov <[email protected]> wrote: > Of course it is for Lift 2.2 branch. Sorry that I haven't specified it > explicitly in summary - you've pointed before that it should be applied to > 2.2 branch, so I've thought that it's clear for all. > > 2011/1/5 Ethan Jewett <[email protected]> > >> Is this patch against the lift 2.2 branch? I think it is but difficult >> to tell from the diff. I will try to apply it tonight. >> >> Ethan >> >> On Wednesday, January 5, 2011, Richard Hirsch <[email protected]> >> wrote: >> > On Wed, Jan 5, 2011 at 5:12 PM, Vladimir Ivanov (JIRA) <[email protected]> >> wrote: >> >> >> >> [ >> https://issues.apache.org/jira/browse/ESME-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel] >> >> >> >> Vladimir Ivanov updated ESME-321: >> >> --------------------------------- >> >> >> >> Attachment: depr.diff >> >> >> >>> Get rid of deprecated methods >> >>> ----------------------------- >> >>> >> >>> Key: ESME-321 >> >>> URL: https://issues.apache.org/jira/browse/ESME-321 >> >>> Project: ESME >> >>> Issue Type: Task >> >>> Components: Server >> >>> Affects Versions: 1.2 >> >>> Reporter: Vladimir Ivanov >> >>> Priority: Minor >> >>> Fix For: 1.2 >> >>> >> >>> Attachments: depr.diff >> >>> >> >>> Original Estimate: 1h >> >>> Remaining Estimate: 1h >> >>> >> >>> Compiler issues multiple warnings related to usage of methods that have >> been deprecated in Lift 2.2 and Scala 2.8.1. Very likely these methods will >> be removed in future Lift and Scala versions, so it would be better to use >> new methods instead. >> >> >> >> -- >> >> This message is automatically generated by JIRA. >> >> - >> >> You can reply to this email to add a comment to the issue online. >> >> >> >> >> > >> > @Vladimir thanks for creating the diff file . Before we migrate the >> > branch to the trunk, it would probably be a good idea to make these >> > changes as well. >> > >> > D. >> > >> > > > > -- > Best Regards, > Vladimir Ivanov >
