xwm1992 commented on a change in pull request #343:
URL:
https://github.com/apache/incubator-eventmesh/pull/343#discussion_r630698606
##########
File path:
eventmesh-test/src/main/java/org/apache/eventmesh/http/demo/sub/controller/SubController.java
##########
@@ -33,12 +35,17 @@
public static Logger logger = LoggerFactory.getLogger(SubController.class);
+ @Autowired
+ private SubService subService;
+
@RequestMapping(value = "/test", method = RequestMethod.POST)
public String subTest(@RequestBody String message) {
logger.info("=======receive message======= {}",
JSONObject.toJSONString(message));
JSONObject result = new JSONObject();
result.put("retCode", 1);
- return result.toJSONString();
+ String strResult = result.toJSONString();
+ subService.consumeMessage(strResult);
Review comment:
The semantics of this line of code looks like it should pass in the
received message as a parameter, not the result of consumption
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
