SteveYurongSu commented on issue #355: URL: https://github.com/apache/incubator-eventmesh/issues/355#issuecomment-841977854
> slow ? No. First of all this will not have any effect on local builds and this scan will only trigger when a new PR is submitted. Currently each code scan takes about 7 minutes, which is only about a minute longer than Travis CI builds. Considering that these builds are running at the same time, actually checks for each PR will only take about 2 minutes longer after the code scan is introduced. > or hard to pass? Code scanning will give a quality report after each check. We'd better determine whether to merge a PR based on the report. This will prevent developers from introducing new problems :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
