qqeasonchen commented on a change in pull request #433:
URL:
https://github.com/apache/incubator-eventmesh/pull/433#discussion_r670128929
##########
File path: settings.gradle
##########
@@ -18,11 +18,12 @@
rootProject.name = 'EventMesh'
String jdkVersion = "${jdk}"
include 'eventmesh-runtime'
-include 'eventmesh-connector-rocketmq'
include 'eventmesh-sdk-java'
include 'eventmesh-common'
include 'eventmesh-connector-api'
include 'eventmesh-starter'
include 'eventmesh-test'
include 'eventmesh-spi'
+include 'eventmesh-connector-plugin'
+include 'eventmesh-connector-plugin:eventmesh-connector-rocketmq'
Review comment:
Is it possible to build all plugins without dependencies in gradle file
and run specific plugin use configuration?
##########
File path: eventmesh-starter/build.gradle
##########
@@ -16,7 +16,7 @@
*/
dependencies {
- implementation project(":eventmesh-runtime"),
project(":eventmesh-connector-rocketmq")
- testImplementation project(":eventmesh-runtime"),
project(":eventmesh-connector-rocketmq")
+ implementation project(":eventmesh-runtime")
Review comment:
The starter moudle is useless after refactor, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
