ruanwenjun commented on pull request #443:
URL:
https://github.com/apache/incubator-eventmesh/pull/443#issuecomment-882241083
> > LGTM, When I submitted a pr, I found that the file `sChat2.jks` seems to
break the rules in checkStyle, do we need to exclude this file? I am not sure
whether this will happen.
>
> @ruanwenjun Thanks for reviewing!
>
> I have the same question. It seems that `sChat2.jks` is an unexpected
binary file, should we remove the file? @qqeasonchen
If this file is not needed, we can remove it, and if this is needed then we
can filter it like below:
```java
<module name="BeforeExecutionExclusionFileFilter">
<property name="fileNamePattern"
value="./eventmesh-runtime/conf/sChat2.jks$"/>
</module>
```
Or using
[checkStyle-suppressions.xml](https://github.com/checkstyle/checkstyle/blob/master/config/suppressions.xml)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
