qqeasonchen commented on pull request #434: URL: https://github.com/apache/incubator-eventmesh/pull/434#issuecomment-884753995
> > > > @qqeasonchen @ruanwenjun Hi guys, do you have any concerns before merging this PR? Please let me know if I missed anything here. :) > > > > > > > > > @yzhao244 Hi, I have a question, the h2 is a memory database, it seems doesn't support distributed, how can the different eventmesh-runtime sync the schema change? > > > > > > > @qqeasonchen @ruanwenjun Hi guys, do you have any concerns before merging this PR? Please let me know if I missed anything here. :) > > @qqeasonchen I answered your questions below. :) > > 1. Eventmesh-store-api can be moved into eventmesh-store-plugin, just like connector. > Yes, I have pushed my latest changes which moved Eventmesh-store-api to be under eventmesh-store-plugin. > 2. Did all the apis in the openSchema implement now? > Not yet, I am thinking it is better delivering OpenSchema Integration in an incremental delivery fashion. :) .. In total, OpenSchema APIs can be seen as three groups.. /subject/ related APIs, /schema/ related APIs, /config/compatibility related APIs which I would suggest to deliver each group by individually separated PRs. The PR 434 currently delivers /subject/ related APIs. > Three child issues are [Implement OpenSchema Subject APIs #453 > ](https://github.com/apache/incubator-eventmesh/issues/453), [Implement OpenSchema Schema APIs #454](https://github.com/apache/incubator-eventmesh/issues/454), [Implement OpenSchema Compatibility APIs #455](https://github.com/apache/incubator-eventmesh/issues/455) > 3. Did the management apis implement now? > Three new subject APIs (schemaregistry/createSubject, /schemaregistry/readSubjectByName and /schemaregistry/showAllSubjectNames) via ClientManageController. The rest of the OpenSchema APIs will be tracked/implemented by individually separated issues and PRs > 4. Did the sdk implement now? > Sorry, do you mean by eventmesh-sdk-java? All OpenSchema APIs are exposed as a RESTful API via webhook in ClientManageController. @yzhao244 Individually separated PRs is good for me. But it is not very clear about how to use schema when pub/sub events, it seems eventmesh provides a management service for schema only in the request implementations, am i right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
