ruanwenjun commented on a change in pull request #467:
URL:
https://github.com/apache/incubator-eventmesh/pull/467#discussion_r676261173
##########
File path: eventmesh-runtime/build.gradle
##########
@@ -23,14 +23,21 @@ List metrics = [
"io.dropwizard.metrics:metrics-json:4.1.0"
]
-
+List open_telemetry = [
+ "io.opentelemetry:opentelemetry-api:1.3.0",
+ "io.opentelemetry:opentelemetry-sdk:1.3.0",
+ "io.opentelemetry:opentelemetry-sdk-metrics:1.3.0-alpha",
Review comment:
Can we use other stable version? Using alpha does not seem to be a good
choice.
##########
File path:
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/metrics/openTelemetry/OpenTelemetryExporterConfiguration.java
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.eventmesh.runtime.metrics.openTelemetry;
+
+import io.opentelemetry.api.metrics.MeterProvider;
+import io.opentelemetry.exporter.prometheus.PrometheusCollector;
+import io.opentelemetry.sdk.metrics.SdkMeterProvider;
+import io.prometheus.client.exporter.HTTPServer;
+
+import java.io.IOException;
+
+//ues openTelemetry to export metrics data
+public class OpenTelemetryExporterConfiguration {
+
+ private HTTPServer server;//Prometheus server
+
+ int prometheusPort = 19090;//the endpoint to export metrics
Review comment:
It is better to add this to configuration properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
