xwm1992 commented on a change in pull request #463:
URL:
https://github.com/apache/incubator-eventmesh/pull/463#discussion_r678212221
##########
File path:
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/push/retry/EventMeshTcpRetryer.java
##########
@@ -76,15 +75,18 @@ public void pushRetry(DownStreamMsgContext
downStreamMsgContext) {
return;
}
- int maxRetryTimes =
SubcriptionType.SYNC.equals(downStreamMsgContext.subscriptionItem.getType()) ?
1 : eventMeshTCPServer.getEventMeshTCPConfiguration().eventMeshTcpMsgRetryTimes;
+ int maxRetryTimes =
SubcriptionType.SYNC.equals(downStreamMsgContext.subscriptionItem.getType())
+ ?
eventMeshTCPServer.getEventMeshTCPConfiguration().eventMeshTcpMsgSyncRetryTimes
+ :
eventMeshTCPServer.getEventMeshTCPConfiguration().eventMeshTcpMsgAsyncRetryTimes;
if (downStreamMsgContext.retryTimes >= maxRetryTimes) {
- logger.warn("pushRetry fail,retry over maxRetryTimes:{},
retryTimes:{}, seq:{}, bizSeq:{}", maxRetryTimes,
downStreamMsgContext.retryTimes,
- downStreamMsgContext.seq,
EventMeshUtil.getMessageBizSeq(downStreamMsgContext.msgExt));
+ logger.warn("pushRetry fail,retry over maxRetryTimes:{}, pushType:
{}, retryTimes:{}, seq:{}, bizSeq:{}",
downStreamMsgContext.subscriptionItem.getType(),
Review comment:
log args position isn't correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
