xwm1992 commented on a change in pull request #485:
URL:
https://github.com/apache/incubator-eventmesh/pull/485#discussion_r683315279
##########
File path:
eventmesh-common/src/main/java/org/apache/eventmesh/common/config/CommonConfiguration.java
##########
@@ -29,23 +29,13 @@
public String eventMeshName = "";
public String sysID = "5477";
public String eventMeshConnectorPluginType = "rocketmq";
+ public String eventMeshAclPluginType = "acl";
Review comment:
eventMeshAclPluginType -> eventMeshSecurityPluginType is better
##########
File path:
eventmesh-common/src/main/java/org/apache/eventmesh/common/config/CommonConfiguration.java
##########
@@ -29,23 +29,13 @@
public String eventMeshName = "";
public String sysID = "5477";
public String eventMeshConnectorPluginType = "rocketmq";
+ public String eventMeshAclPluginType = "acl";
public String namesrvAddr = "";
- public String clientUserName = "username";
- public String clientPass = "user@123";
- public Integer consumeThreadMin = 2;
- public Integer consumeThreadMax = 2;
- public Integer consumeQueueSize = 10000;
- public Integer pullBatchSize = 32;
- public Integer ackWindow = 1000;
- public Integer pubWindow = 100;
- public long consumeTimeout = 0L;
- public Integer pollNameServerInteval = 10 * 1000;
- public Integer heartbeatBrokerInterval = 30 * 1000;
- public Integer rebalanceInterval = 20 * 1000;
public Integer eventMeshRegisterIntervalInMills = 10 * 1000;
public Integer eventMeshFetchRegistryAddrInterval = 10 * 1000;
public String eventMeshServerIp = null;
+ public boolean eventMeshServerAclEnable = false;
Review comment:
like above
##########
File path: eventmesh-runtime/conf/eventmesh.properties
##########
@@ -56,4 +56,8 @@
eventMesh.server.registry.fetchRegistryAddrIntervalInMills=20000
#eventMesh.server.defibus.client.comsumeTimeoutInMin=5
#connector plugin
-eventMesh.connector.plugin.type=rocketmq
\ No newline at end of file
+eventMesh.connector.plugin.type=rocketmq
+
+#acl plugin
+eventMesh.server.acl.enabled=false
+eventMesh.acl.plugin.type=acl
Review comment:
eventMesh.server.security.enabled & eventMesh.security.plugin.type maybe
better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
