xwm1992 commented on a change in pull request #603:
URL:
https://github.com/apache/incubator-eventmesh/pull/603#discussion_r754767448
##########
File path:
eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/http/consumer/EventMeshHttpConsumer.java
##########
@@ -191,6 +183,7 @@ private RequestParam buildCommonRequestParam() {
.addHeader(ProtocolKey.ClientInstanceKey.SYS,
eventMeshHttpClientConfig.getSys())
.addHeader(ProtocolKey.ClientInstanceKey.USERNAME,
eventMeshHttpClientConfig.getUserName())
.addHeader(ProtocolKey.ClientInstanceKey.PASSWD,
eventMeshHttpClientConfig.getPassword())
+ // add protocol version?
.addHeader(ProtocolKey.VERSION, ProtocolVersion.V1.getVersion())
Review comment:
here version is http version just http 1.0, 1.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
