jinrongluo commented on a change in pull request #723:
URL:
https://github.com/apache/incubator-eventmesh/pull/723#discussion_r787880261
##########
File path: docs/cn/instructions/eventmesh-runtime-protocol.md
##########
@@ -290,7 +290,7 @@ message RequestHeader {
string protocolDesc = 12;
}
-message EventMeshMessage {
+message SimpleMessage {
Review comment:
in my opinion, the naming need to be consistent across the protocol.
If we choose to use MessageRequest, then we have to add "Request" to the
other message names as well: "BatchMessageRequest", "SubscriptionRequest",
"HeartBeatRequest".
But I also think adding the word "Request" is a little bit redundant,
because this is already a GRPC request message in nature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
