Alonexc opened a new issue, #838:
URL: https://github.com/apache/incubator-eventmesh/issues/838

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Enhancement Request
   
   I found a lot of useless code and some useless classes in the 
eventmesh-runtime module and recommended removing them.
   
   ### Describe the solution you'd like
   
   Such as:
   
![image](https://user-images.githubusercontent.com/91315508/164183279-213443fc-2fe6-4cf3-8e2b-3baea6e62f12.png)
   
![image](https://user-images.githubusercontent.com/91315508/164183338-e6e35537-b6d9-4f95-b65a-2685b8a5a6f5.png)
   
   We can remove the useless code, it is located in:
   
1.eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/inf
 
package,ReplyMessageProcessor.class、SendAsyncMessageProcessor.class、BatchSendMessageProcessor.class
   
2.eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/group/ClientGroupWrapper.java
   
3.eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/push/ClientAckContext.java
   
4.eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/push/DownStreamMsgContext.java
   
5.eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/send/SessionSender.java
   
6.eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/Session.java
   
7.eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/HelloTask.java
   
8.eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/ListenTask.java
   9.eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/domain
   These two interfaces are not used,we can remove the domain package and these 
two interfaces.
   
![image](https://user-images.githubusercontent.com/91315508/164185157-760ca900-f6e8-42bc-8f6d-517ecb776950.png)
   
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to