Alonexc opened a new issue, #844:
URL: https://github.com/apache/incubator-eventmesh/issues/844

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Enhancement Request
   
   Clean up some useless constants and classes in the 
eventmesh-connector-plugin module.
   
   ### Describe the solution you'd like
   
   located 
in:eventmesh-connector-plugin/eventmesh-connector-rocketmq/src/main/java/org/apache/eventmesh/connector/rocketmq/common
   The Constants and EventMeshContants classes in this package have a large 
number of unused Constants,we can remove them.
   
![image](https://user-images.githubusercontent.com/91315508/165042752-34c9345b-a86d-47d6-9268-b6340618ba49.png)
   
![image](https://user-images.githubusercontent.com/91315508/165042837-8ed01335-0b35-4798-9597-1bed48cfc1cd.png)
   
   
eventmesh-connector-plugin/eventmesh-connector-rocketmq/src/main/java/org/apache/eventmesh/connector/rocketmq/domain/NonStandardKeys.java
 There are unused keys in this class
   
![image](https://user-images.githubusercontent.com/91315508/165043669-83389e01-6e4c-4e27-bb83-5b0975775287.png)
   
   ConsumeRequest and RocketMQConstants, under the same package, are not used.
   
![image](https://user-images.githubusercontent.com/91315508/165045062-f379d5f2-0e7d-4dcc-81c7-2765eed2eabf.png)
   
![image](https://user-images.githubusercontent.com/91315508/165045096-0061e9dd-4855-4efb-b0d4-a59f72bc2aed.png)
   
   
eventmesh-connector-plugin/eventmesh-connector-rocketmq/src/main/java/org/apache/eventmesh/connector/rocketmq/promise/FutureState.java
 This class is useless, so we can remove this package and this class.
   
![image](https://user-images.githubusercontent.com/91315508/165045427-982ac485-9d27-4458-9b0a-0fe5b8b303da.png)
   
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to