xwm1992 commented on code in PR #849: URL: https://github.com/apache/incubator-eventmesh/pull/849#discussion_r866759942
########## tools/third-party-dependencies/known-dependencies.txt: ########## @@ -130,4 +130,5 @@ httpcore-nio-4.4.6.jar javassist-3.21.0-GA.jar nacos-client-2.0.4.jar reflections-0.9.11.jar -snakeyaml-1.23.jar \ No newline at end of file +snakeyaml-1.23.jar +spring-boot-starter-web-2.6.7.jar Review Comment: > Currently, the check license script will only check the third-part libs in distribution. If we didn't add the example module in distribution, we can't add `spring-boot-starter-web-2.6.7.jar ` in this file, otherwise the license check will fail. Ok, I get what you mean, we either only upgrade the `spring-boot-starter-web-2.6.7.jar` version and not add this to the file `known-dependencies.txt`, or add the `example moudule` into the distribution ? I prefer the former, not add `spring-boot-starter-web-2.6.7.jar` to the files, because the `example` don't need to be used in distributions. @misselvexu @ruanwenjun what's your opinion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
