ruanwenjun commented on code in PR #966:
URL:
https://github.com/apache/incubator-eventmesh/pull/966#discussion_r906747382
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/RemotingHelper.java:
##########
@@ -50,6 +50,9 @@ public static String exceptionSimpleDesc(final Throwable e) {
public static SocketAddress string2SocketAddress(final String addr) {
int split = addr.lastIndexOf(":");
+ if (split == -1) {
Review Comment:
It's better to not do these kinds of changes in this PR, you just want to
add UT right? Please revert the extra change.
##########
build.gradle:
##########
@@ -465,8 +465,8 @@ subprojects {
dependency "com.github.stefanbirkner:system-rules:1.16.1"
dependency "org.assertj:assertj-core:2.6.0"
- dependency "org.mockito:mockito-core:2.23.0"
- dependency "org.mockito:mockito-inline:3.6.28"
+ dependency "org.mockito:mockito-core:3.8.0"
+ dependency "org.mockito:mockito-inline:3.8.0"
Review Comment:
Is there any reason we need to upgrade these version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
