kirinzhu opened a new issue, #999:
URL: https://github.com/apache/incubator-eventmesh/issues/999

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Enhancement Request
   
   This class implements the Comparator interface. Maybe we consider whether or 
not it should also implement the Serializable interface. If a comparator is 
used to construct an ordered collection such as a TreeMap, then the TreeMap 
will be serializable only if the comparator is also serializable. Making them 
serializable is good defensive programming and could enhance the robustness of 
the program
   
   ### Describe the solution you'd like
   
   In module eventmesh-runtime
   In class org.apache.eventmesh.runtime.util.ValueComparator
   At [lines 23-29]
   
   Consider implementing the Serializable interface
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to