pchengma opened a new pull request, #1027:
URL: https://github.com/apache/incubator-eventmesh/pull/1027

   <!--
   ### Contribution Checklist
   
     - Name the pull request in the form "[ISSUE #XXXX] Title of the pull 
request", 
       where *XXXX* should be replaced by the actual issue number.
       Skip *[ISSUE #XXXX]* if there is no associated github issue for this 
pull request.
   
     - Fill out the template below to describe the changes contributed by the 
pull request. 
       That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue. 
       Please do not mix up code from multiple issues.
     
     - Each commit in the pull request should have a meaningful commit message.
   
     - Once all items of the checklist are addressed, remove the above text and 
this checklist, 
       leaving only the filled out template below.
   
   (The sections below can be removed for hotfixes of typos)
   -->
   
   <!--
   (If this PR fixes a GitHub issue, please add `Fixes ISSUE #<XXX>`.)
   -->
   
   Fixing ISSUE #790.
   
   ### Motivation
   
   *Implemented and tested Producer module to deliver an event to Knative 
([ISSUE #790](https://github.com/apache/incubator-eventmesh/issues/790)).*
   *The PRs for [ISSUE 
#790](https://github.com/apache/incubator-eventmesh/issues/790) will be merged 
into knative-connector branch*
   
   
   
   ### Modifications
   
   *Followed the API design style of 
[eventmesh-connector-rocketmq](https://github.com/apache/incubator-eventmesh/tree/master/eventmesh-connector-plugin/eventmesh-connector-rocketmq/src/main/java/org/apache/eventmesh/connector/rocketmq)
 and made the following modifications*
   
   #### Implementation:
   - Producer for delivering an event message to Knative
   - CloudEvent Reader, Writer, and Header
   - Connector
   - Unit test for Producer
   - Included eventmesh-connector-knative in setting.gradle
   
   #### How to Test:
   
   *Assume the cloudevents-player Knative service has already been set up on 
your local machine; otherwise, please follow the steps in 
https://knative.dev/docs/getting-started/first-source/#sending-an-event to set 
up a Knative service (cloudevents-player) as a source.*
   
   ```bash
   # Do unit test:
   $ cd 
incubator-eventmesh/eventmesh-connector-plugin/eventmesh-connector-knative
   $ ../../gradlew clean test
   # See the delivered event:
   $ curl http://cloudevents-player.default.127.0.0.1.sslip.io/messages
   ```
   
   ### Documentation
   
   - Does this pull request introduce a new feature? yes.
   - If yes, how is the feature documented? not documented.
   - If a feature is not documented yet in this PR, please create a followup 
issue for adding the documentation. The followup issues or pull requests for 
documentation will be created after almost all implementation work has been 
finished.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to